Hi Amber, Thanks for reviewing and Acking!
> -----Original Message----- > From: Amber, Kumar <[email protected]> > Sent: Tuesday 22 February 2022 06:15 > To: [email protected] > Cc: [email protected]; Ferriter, Cian <[email protected]> > Subject: RE: [PATCH] dpif-netdev: Simplify atomic function pointer stores > > Hi Cian, > > Thanks for the Patch. > > I have tested the patch and reviewed as well. > One small minor comment . > > > + atomic_store_relaxed(&pmd->miniflow_extract_opt, > > + miniflow_funcs[MFEX_IMPL_SCALAR].extract_func); > > VLOG_INFO("Not enough packets matched (%u/%u), disabling" > > " optimized MFEX.", max_hits, stats->pkt_count); > > Alignment of the comment is off. > Yes, unfortunately I couldn't wrap the atomic_store_relaxed line and keep the alignment as we'd like. If I do that, the line is 80 characters long which is just over the 79 character limit. > Acked-by: Kumar Amber <[email protected]> > > Regards > Amber _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
