On 2/25/22 01:48, Han Zhou wrote:
On Thu, Feb 24, 2022 at 9:31 AM Mark Michelson <[email protected]
<mailto:[email protected]>> wrote:
>
> This provides some missing documentation about the OVS submodule.
>
> It also proposes a currently-unimplemented policy wherein we attempt
> to base OVN releases on a stable OVS release branch instead of
> arbitrary commits.
>
Thanks Mark. This looks good to me. Just one comment inlined.
> Signed-off-by: Mark Michelson <[email protected]
<mailto:[email protected]>>
> ---
> Documentation/internals/ovs_submodule.rst | 98 +++++++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 Documentation/internals/ovs_submodule.rst
>
> diff --git a/Documentation/internals/ovs_submodule.rst
b/Documentation/internals/ovs_submodule.rst
> new file mode 100644
> index 000000000..ec962d438
> --- /dev/null
> +++ b/Documentation/internals/ovs_submodule.rst
> @@ -0,0 +1,98 @@
> +..
> + Licensed under the Apache License, Version 2.0 (the
"License"); you may
> + not use this file except in compliance with the License. You
may obtain
> + a copy of the License at
> +
> + http://www.apache.org/licenses/LICENSE-2.0
<http://www.apache.org/licenses/LICENSE-2.0>
> +
> + Unless required by applicable law or agreed to in writing,
software
> + distributed under the License is distributed on an "AS IS"
BASIS, WITHOUT
> + WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied. See the
> + License for the specific language governing permissions and
limitations
> + under the License.
> +
> + Convention for heading levels in OVN documentation:
> +
> + ======= Heading 0 (reserved for the title in a document)
> + ------- Heading 1
> + ~~~~~~~ Heading 2
> + +++++++ Heading 3
> + ''''''' Heading 4
> +
> + Avoid deeper levels because they do not render well.
> +
> +=============
> +OVS Submodule
> +=============
> +
> +Prior to 2020, OVN did not exist as its own repo. Instead, OVN was a
> +subdirectory within OVS. OVN grew up being closely intertwined with OVS.
> +Compiling OVS would also compile OVN. OVN used OVS libraries
directly, and
> +there was no concern about trying to maintain any level of compatibility
> +between OVS and OVN since they were the same codebase.
> +
> +In 2020, OVN was split off from OVS. This meant that it became
necessary to
> +consider compatibility between OVS and OVN. At compile time, we use
a submodule
> +to ensure that OVS libraries that OVN relies on will behave as expected.
> +Runtime compatibility is a separate topic outside the scope of this
document.
> +
> +Developing with the OVS submodule
> +---------------------------------
> +
> +Most OVN development will happen independently of the OVS submodule.
However,
> +there may be times that in order to make a change in OVN, an
accompanying
> +change is required in OVS as well. For instance, it may be that a
change to
> +OVSDB's client API is required for OVN to fix a bug.
> +
> +In this situation, make the necessary OVS change first and submit
this fix to
> +OVS based on their current code submission guidelines. Once the
change has been
> +accepted by OVS, then you can submit an OVN patch that includes
changing the
> +submodule to point at the OVS commit where your change was accepted.
> +
> +Submodules for releases
> +-----------------------
> +
> +For OVN releases, it is preferred for the OVS submodule to point to
a stable
> +release branch of OVS. Therefore, as part of the release process for
OVN, we
> +will point the submodule to the latest stable branch of OVS before
releasing.
> +
> +The exception to this is if the current OVS submodule is pointing to
a commit
> +that is not in a current stable branch of OVS. In that case, the
submodule
> +will continue to point to that particular commit. We may, however,
bump the
> +submodule to the next stable branch of OVS at a later time.
> +
> +As an example, let's assume that the OVS commit history looks
something like
> +this in the main branch:
> +
> +(Newest)
> +Commit 3
> + |
> + |
> +Commit 2 (used to create OVS branch-Y)
> + |
> + |
> +Commit 1
> +(Oldest)
> +
> +Let's say that we are planning to release OVN version X. At this
point, the
> +submodule is pointing to Commit 1. As part of the release process,
we will bump
> +the OVS submodule in OVN to point to Commit 2, or more likely the
tip of OVS
> +branch-Y. This way, the released version of OVN is based on a stable
release
> +branch of OVS, and it has all of the necessary changes that we require.
> +
> +What if the OVS submodule currently points to Commit 3, though?
There is no
> +stable branch that exists after this commit. In this case, we will
create OVN
> +release X and point the OVS submodule to Commit 3. At a later time,
if it makes
Shall we mention that this can be avoided in most cases if the related
OVS fix (e.g. commit 3) required by OVN are backported to the stable OVS
branch if possible?
Sure, I'll add this note. Thanks for the review, Han.
With this addressed:
Acked-by: Han Zhou <[email protected] <mailto:[email protected]>>
> +sense to do so, we may bump the submodule to OVS branch-Z when it is
released.
> +It depends on several factors:
> +
> +- Is OVN release X still being supported?
> +- Is there any known benefit to updating the submodule? E.g., are there
> + performance improvements we could take advantage of by updating the
> + submodule?
> +- Is there risk in updating the submodule?
> +
> +For a LTS of OVN, we might update the submodule several times during its
> +lifetime as more new OVS branches are released. For a standard
release, it is
> +less likely that we will update the OVS submodule during the
standard release's
> +lifetime.
> --
> 2.31.1
>
> _______________________________________________
> dev mailing list
> [email protected] <mailto:[email protected]>
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
