> -----Original Message-----
> From: Amber, Kumar <[email protected]>
> Sent: Tuesday 1 March 2022 15:08
> To: [email protected]
> Cc: Ferriter, Cian <[email protected]>; [email protected]; Stokes,
> Ian <[email protected]>;
> Van Haaren, Harry <[email protected]>; Amber, Kumar
> <[email protected]>
> Subject: [PATCH v2] system-dpdk: Fix mfex autovalidator tests.
>
> AVX512 DPIF must be active in order for the MFEX AutoValidator to be executed.
> If the DPIF-AVX512 is not available, the unit test is skipped, as the
> scalar DPIF does not use the MFEX function-pointer based optimizations.
>
> Fixes: 50be6715c0 ("test/sytem-dpdk: Add unit test for mfex autovalidator")
> Suggested-by: Cian Ferriter <[email protected]>
> Signed-off-by: Kumar Amber <[email protected]>
Hi Amber,
Thanks for addressing the changes.
This patch LGTM. I have also tested that the unit tests are being run by
introducing an error in the MFEX C code and running the unit tests. The errors
are caught and the MFEX autovalidator tests fail.
Acked-by: Cian Ferriter <[email protected]>
More information about my testing:
Before introducing errors in the C code the tests pass:
~/ovs# make check-dpdk TESTSUITEFLAGS='-k MFEX -d'
<snip>
OVS-DPDK unit tests
6: OVS-DPDK - MFEX Autovalidator ok
7: OVS-DPDK - MFEX Autovalidator Fuzzy ok
8: OVS-DPDK - MFEX Configuration ok
I introduce the following error:
lib/dpif-netdev-extract-avx512.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c
index c1c1fefb6..f31d64889 100644
--- a/lib/dpif-netdev-extract-avx512.c
+++ b/lib/dpif-netdev-extract-avx512.c
@@ -172,7 +172,7 @@ _mm512_maskz_permutexvar_epi8_wrap(__mmask64 kmask, __m512i
idx, __m512i a)
#define NU 0
#define PATTERN_IPV4_UDP_SHUFFLE \
- 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, NU, NU, /* Ether */ \
+ 26, 27, 28, 29, 30, 31, 32, 33, NU, NU, NU, NU, 20, 15, 22, 23, /* IPv4 */ \
26, 27, 28, 29, 30, 31, 32, 33, NU, NU, NU, NU, 20, 15, 22, 23, /* IPv4 */ \
34, 35, 36, 37, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, /* UDP */ \
NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, NU, /* Unused. */
And the tests fail as expected:
~/ovs# make check-dpdk TESTSUITEFLAGS='-k MFEX -d'
<snip>
OVS-DPDK unit tests
6: OVS-DPDK - MFEX Autovalidator FAILED (system-dpdk.at:252)
7: OVS-DPDK - MFEX Autovalidator Fuzzy FAILED (system-dpdk.at:284)
8: OVS-DPDK - MFEX Configuration ok
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
