Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#77 FILE: include/openvswitch/hmap.h:182:
HMAP_FOR_EACH_SAFE_INIT (NODE, NEXT, MEMBER, HMAP, (void) NEXT)
ERROR: Inappropriate bracing around statement
#114 FILE: lib/ovs-numa.h:71:
HMAP_FOR_EACH (ITER, hmap_node, &(DUMP)->cores)
ERROR: Inappropriate bracing around statement
#118 FILE: lib/ovs-numa.h:74:
HMAP_FOR_EACH (ITER, hmap_node, &(DUMP)->numas)
ERROR: Use ovs_assert() in place of assert()
#129 FILE: tests/test-hmap.c:65:
assert(e == NULL);
ERROR: Use ovs_assert() in place of assert()
#137 FILE: tests/test-hmap.c:86:
assert(e == NULL);
ERROR: Use ovs_assert() in place of assert()
#146 FILE: tests/test-hmap.c:249:
assert(next == NULL);
ERROR: Use ovs_assert() in place of assert()
#148 FILE: tests/test-hmap.c:251:
assert(&next->node == hmap_next(&hmap, &e->node));
ERROR: Use ovs_assert() in place of assert()
#157 FILE: tests/test-hmap.c:269:
assert(next == NULL);
ERROR: Use ovs_assert() in place of assert()
#158 FILE: tests/test-hmap.c:270:
assert(e == NULL);
Lines checked: 165, Warnings: 0, Errors: 9
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
