On Thu, Mar 17, 2022 at 7:36 AM Mohammad Heib <[email protected]> wrote: > > IPsec unit tests uses tcpdump to capture and validate the ESP > traffic so the test must be skipped in environment that don't > have the tcpdump tool installed. > > Signed-off-by: Mohammad Heib <[email protected]>
Doesn't system-traffic.at also use tcpdump? When would system-ipsec.at be run but not system-traffic.at ? Cheers, MKP > --- > tests/system-ipsec.at | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/system-ipsec.at b/tests/system-ipsec.at > index f45a153ed..888f79120 100644 > --- a/tests/system-ipsec.at > +++ b/tests/system-ipsec.at > @@ -99,9 +99,10 @@ dnl Check if necessary Libreswan dependencies are > available on the test machine > m4_define([CHECK_LIBRESWAN], > [dnl Skip tests if system has not been set up for Libreswan > AT_SKIP_IF([!(ipsec --version | grep Libreswan)]) > - AT_SKIP_IF([test ! -x $(which certutil)]) > - AT_SKIP_IF([test ! -x $(which pk12util)]) > - AT_SKIP_IF([test ! -x $(which openssl)]) > + AT_SKIP_IF([test ! $(which certutil)]) > + AT_SKIP_IF([test ! $(which pk12util)]) > + AT_SKIP_IF([test ! $(which openssl)]) > + AT_SKIP_IF([test ! $(which tcpdump)]) > dnl If '$ovs_base' is too long, the following Libreswan issue will > trigger > dnl so we check that it is not too long and skip test if it is. > dnl https://github.com/libreswan/libreswan/issues/428 > -- > 2.31.1 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
