On 21 Mar 2022, at 10:06, Ilya Maximets wrote:
> On 2/22/22 16:19, Eelco Chaudron wrote: >> This series fixes a bunch of TC offload-related issues found when >> running the kernel data path self-test (make check-kernel) forcing >> TC to be enabled. To do this manually I applied the following diff: >> >> https://github.com/chaudron/ovs/commit/d7ff1060f371e2cbd4b2e8dee222a9eed55073c8 >> >> These changes are OVS-related fixes, however, I have still two >> problems that look kernel to investigate. >> >> I'm also planning to find a nice way to include the system-traffic.at >> into "make check-offloads". However, this might take some time, and I >> do not want to delay getting the actual fixes in. >> >> The following branch has some raw changes to system-traffic.at to >> make most of the tests work with TC enabled hardcoded: >> >> https://github.com/chaudron/ovs/tree/dev/tc_verify >> >> v2: >> - Fixed sparse "expected restricted ovs_be16" warning >> - Removed patch "netdev-offload-tc: stats should be captured on first >> action in the list" >> - Added new patch "odp-util: Fix output for tc to be equal to kernel" >> >> v3: >> - [4/10] Fixed netdev reference issue on failure >> - [4/10] Added netdev_flow_api_equals() check >> - [8/10] Instead of warning about an invalid CT flag combination fix it >> - [9/10] Removing patch 9, "revalidator: Fix datapath statistics update" >> >> Eelco Chaudron (9): >> netdev-offload-tc: Add debug logs on tc rule verify failures >> netdev-offload-tc: Set the correct VLAN_VID and VLAN_PCP masks >> odp_util: Fix parse_key_and_mask_to_match() vlan parsing >> netdev-offload-tc: Check for valid netdev ifindex in flow_put >> netdev-offload-tc: Always include conntrack information to tc >> netdev-offload-tc: Fix use of ICMP values instead of masks defines. >> netdev-offload-tc: Fix IP and port ranges in flower returns. >> netdev-offload-tc: Check for none offloadable ct_state flag combination >> odp-util: Fix output for tc to be equal to kernel >> >> >> lib/netdev-offload-tc.c | 24 ++++++++ >> lib/odp-util.c | 46 ++++++++++----- >> lib/tc.c | 124 ++++++++++++++++++++++++++++++++-------- >> tests/tunnel.at | 2 +- >> 4 files changed, 157 insertions(+), 39 deletions(-) >> > > Thanks! That is a good cleanup. > I applied the set except for patches #3 (vlan limit) and #8 (+trk). > For #3 there is one unresolved comment in v2 and I want to take another > look at #8 since I didn't follow the discussion close enough. Thanks Ilya! I think I missed the #3 comment. Let me take a look, and reply, and I’ll wait for #8. > Patches also backported down to 2.13, except for the ICMP fix that is > backported down to 2.16. > > Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
