> -----Original Message----- > From: Amber, Kumar <[email protected]> > Sent: Tuesday, March 15, 2022 4:12 AM > To: [email protected] > Cc: [email protected]; Ferriter, Cian <[email protected]>; Stokes, Ian > <[email protected]>; [email protected]; [email protected]; Van Haaren, > Harry <[email protected]>; Amber, Kumar <[email protected]> > Subject: [PATCH v6 2/6] dpif-netdev/mfex: Add ipv4 profile based hashing. > > This commit adds IPv4 profile specific hashing which > uses fixed offsets into the packet to improve hashing > perforamnce.
Nit; typo "performance" > > Signed-off-by: Kumar Amber <[email protected]> > Signed-off-by: Harry van Haaren <[email protected]> > Co-authored-by: Harry van Haaren <[email protected]> This patchset currently contains 2 things; 1) Hashing Optimizations 2) IPv6 traffic support I suggest to split these into two separate patchsets, to enable forward progress to be made with merging the hashing component (patches 2, 4, 5, 6). The IPv6 traffic profile relates to the "Miniflow ABI break/update" topic, as Ilya flagged to Amber/Cian and myself. As a result of the miniflow change, the IPv6 code must be adjusted a little, so we can hold off on merging that until after the IPv6 extension headers patch is merged? That would mean; 1) Amber to send IPv4 hashing (and related testing/validation) patches separately as v7 2) Amber/Cian/Harry to check MF ABI break for IPv6 ext-headers patch, and adjust the AVX512 IPv6 code to reflect the new Miniflow layout, then send patchset to support AVX512 mfex for IPv6 + Hashing. I think this approach allows progress to be made on code that is ready to merge, and is the right approach to getting MF ABI change and AVX512 IPv6 support integrated. Regards, -Harry _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
