On 22/03/2022 15:35, David Marchand wrote:
On Fri, Mar 11, 2022 at 6:06 PM Kevin Traynor <[email protected]> wrote:
Nit: the title is a bit scary, while this fix only matters when using
cores from (strictly) more than 2 numas in OVS.
To help users understand the impact of the issue/fix, I would add a
comment about the "strictly more than 2 numas" setup at the beginning
of the commitlog before entering the details.
Sure, I'll mention >2 numas in the first para, that will tell most
people that it doesn't impact them.
In the event of no pmd cores available on the local numa for
an rxq to be assigned to, a pmd core from a non-local numa is
selected.
If there are more than one non-local numas with pmd cores they
are RR through and checked if they have non-isolated pmds.
When successfully finding a non-local numa with available pmds
for an rxq, that numa was not being stored. It meant if a similar
situation occurred for a subsequent rxq, the same numa would be
selected again.
Store the last numa used when successfully finding a non-local numa
with available pmds, so the numa RR state is kept for subsequent rxqs.
Fixes: f577c2d046b2 ("dpif-netdev: Rework rxq scheduling code.")
Signed-off-by: Kevin Traynor <[email protected]>
Acked-by: Mike Pattrick <[email protected]>
Acked-by: David Marchand <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
