On Tue, Mar 29, 2022 at 3:19 PM Kevin Traynor <[email protected]> wrote: > > Previously logging about rxq scheduling was done in a code branch with > the selection of the PMD thread core after checking that a numa was > selected. > > By splitting out the logging from the PMD thread core selection, it can > simplify the code complexity and make it more extendable for future > additions. > > Also, minor updates to a couple of variables to improve readability and > fix a log indent while working on this code block. > > There is no user visibile change in behaviour or logs.
visible* > > Signed-off-by: Kevin Traynor <[email protected]> I have two small comments (see below), but otherwise: Acked-by: David Marchand <[email protected]> > --- > lib/dpif-netdev.c | 59 +++++++++++++++++++++++++---------------------- > 1 file changed, 32 insertions(+), 27 deletions(-) > > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 40a62fd9f..dc414ae8f 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -5991,5 +5991,6 @@ sched_numa_list_schedule(struct sched_numa_list > *numa_list, > struct sched_pmd *sched_pmd = NULL; > struct sched_numa *numa; > - int numa_id; > + int port_numa_id; > + int pmd_numa_id; pmd_numa_id can be moved to the block where a pmd has been selected. > uint64_t proc_cycles; > char rxq_cyc_log[MAX_RXQ_CYC_STRLEN]; > @@ -6003,7 +6004,8 @@ sched_numa_list_schedule(struct sched_numa_list > *numa_list, > /* Store the cycles for this rxq as we will log these later. */ > proc_cycles = dp_netdev_rxq_get_cycles(rxq, RXQ_CYCLES_PROC_HIST); > - /* Select the numa that should be used for this rxq. */ > - numa_id = netdev_get_numa_id(rxq->port->netdev); > - numa = sched_numa_list_lookup(numa_list, numa_id); > + port_numa_id = netdev_get_numa_id(rxq->port->netdev); > + Nit: this makes port_numa_id next to a block with an unrelated comment. I would add a separating newline. > + /* Select numa. */ > + numa = sched_numa_list_lookup(numa_list, port_numa_id); > > /* Check if numa has no PMDs or no non-isolated PMDs. */ -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
