Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Veda Barrenkala <[email protected]> needs to sign off. WARNING: Line is 98 characters long (recommended limit is 79) #60 FILE: ovn-nb.ovsschema:313: "enum": ["set", ["from-lport", "to-lport","both"]]}}}, WARNING: Line is 82 characters long (recommended limit is 79) #63 FILE: ovn-nb.ovsschema:316: "enum": ["set", ["gre", "erspan"]]}}}, WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #246 FILE: utilities/ovn-nbctl.c:275: mirror-add NAME TYPE INDEX FILTER {IP|PORT}\n\ WARNING: Line lacks whitespace around operator #249 FILE: utilities/ovn-nbctl.c:278: specify INDEX gre key/erpsan idx\n\ WARNING: Line lacks whitespace around operator #251 FILE: utilities/ovn-nbctl.c:280: specify Sink/Destination IP or port\n\ WARNING: Line lacks whitespace around operator #252 FILE: utilities/ovn-nbctl.c:281: mirror-del [NAME]\n\ WARNING: Line lacks whitespace around operator #262 FILE: utilities/ovn-nbctl.c:324: lsp-attach-mirror PORT MIRROR attach source PORT to the MIRROR\n\ WARNING: Line lacks whitespace around operator #263 FILE: utilities/ovn-nbctl.c:325: lsp-detach-mirror PORT MIRROR detach source PORT from the MIRROR\n\ WARNING: Line is 80 characters long (recommended limit is 79) #275 FILE: utilities/ovn-nbctl.c:1697: ovsdb_idl_add_column(ctx->idl, &nbrec_logical_switch_port_col_mirror_rules); ERROR: Improper whitespace around control block #307 FILE: utilities/ovn-nbctl.c:1729: NBREC_MIRROR_FOR_EACH(mirror, ctx->idl) { WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #424 FILE: utilities/ovn-nbctl.c:7175: const struct nbrec_logical_switch_port *lsp=NULL; ERROR: C99 style comment #429 FILE: utilities/ovn-nbctl.c:7180: //check if it is a valid ip. ERROR: Inappropriate spacing in pointer declaration WARNING: Line lacks whitespace around operator #445 FILE: utilities/ovn-nbctl.c:7196: char* ip_p = NULL; WARNING: Line is 85 characters long (recommended limit is 79) #493 FILE: utilities/ovn-nbctl.c:7244: ovsdb_idl_add_column(ctx->idl, &nbrec_logical_switch_port_col_dynamic_addresses); ERROR: Improper whitespace around control block #516 FILE: utilities/ovn-nbctl.c:7267: NBREC_MIRROR_FOR_EACH(mirror_check, ctx->idl) { WARNING: Line lacks whitespace around operator #542 FILE: utilities/ovn-nbctl.c:7293: error = parse_sink(ctx,&sink_ip, &laddrs, &used_laddrs); ERROR: Improper whitespace around control block WARNING: Line lacks whitespace around operator #637 FILE: utilities/ovn-nbctl.c:7388: if(mirror->n_src>0){ Lines checked: 682, Warnings: 16, Errors: 6 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
