On Tue, Apr 5, 2022 at 11:00 AM Mark Michelson <[email protected]> wrote: > > Acked-by: Mark Michelson <[email protected]> > Applied, thanks!
Han > On 3/30/22 01:50, Han Zhou wrote: > > The comment is misleading. The conjunctive match IDs always starts from > > 1 instead of 0. > > > > Signed-off-by: Han Zhou <[email protected]> > > --- > > lib/expr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/expr.c b/lib/expr.c > > index 47ef6108e..caae0d4b2 100644 > > --- a/lib/expr.c > > +++ b/lib/expr.c > > @@ -3257,7 +3257,7 @@ add_cmp_flow(const struct expr *cmp, > > * a collection of Open vSwitch flows in 'matches', which this function > > * initializes to an hmap of "struct expr_match" structures. Returns the > > * number of conjunctive match IDs consumed by 'matches', which uses > > - * conjunctive match IDs beginning with 0; the caller must offset or remap them > > + * conjunctive match IDs beginning with 1; the caller must offset or remap them > > * into the desired range as necessary. > > * > > * The matches inserted into 'matches' will be of three distinct kinds: > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
