On 4/20/22 07:55, Adrian Moreno wrote: > Remove the use of the next variable when possible in _SAFE loops. > This makes code more readable and less error prone. > > Signed-off-by: Adrian Moreno <[email protected]> > ---
This looks good to me overall! There's just one place where we missed updating the _SAFE loop. I guess however that the incremental below can be squashed together with your patch by the maintainers at apply time. With that in mind: Acked-by: Dumitru Ceara <[email protected]> Thanks! --- diff --git a/northd/northd.c b/northd/northd.c index 5128f1f96..a8f9af9a5 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -15129,8 +15129,8 @@ build_static_mac_binding_table(struct northd_input *input_data, /* Cleanup SB Static_MAC_Binding entries which do not have corresponding * NB Static_MAC_Binding entries. */ const struct nbrec_static_mac_binding *nb_smb; - const struct sbrec_static_mac_binding *sb_smb, *sb_smb_next; - SBREC_STATIC_MAC_BINDING_TABLE_FOR_EACH_SAFE (sb_smb, sb_smb_next, + const struct sbrec_static_mac_binding *sb_smb; + SBREC_STATIC_MAC_BINDING_TABLE_FOR_EACH_SAFE (sb_smb, input_data->sbrec_static_mac_binding_table) { nb_smb = static_mac_binding_by_port_ip(input_data, sb_smb->logical_port, _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
