yangchang <[email protected]> writes: > If the flow contains protocol types, that the later fragment packets of > UDP6 and ICMPv6 cannot hit the flow. So the later fragment packets should > be set next header protocl types, too. > > Signed-off-by: yangchang <[email protected]> > ---
How does this change the discussion at: http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ The approach we proposed was: http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ Is there something else we should have considered with Paolo's patch? I think I'm missing something. > lib/flow.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/flow.c b/lib/flow.c > index dd523c8..84c2e84 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -539,7 +539,6 @@ parse_ipv6_ext_hdrs__(const void **datap, size_t *sizep, > uint8_t *nw_proto, > *nw_frag = FLOW_NW_FRAG_ANY; > if (((*frag_hdr)->ip6f_offlg & IP6F_OFF_MASK) != htons(0)) { > *nw_frag |= FLOW_NW_FRAG_LATER; > - *nw_proto = IPPROTO_FRAGMENT; > return true; > } > } > @@ -557,9 +556,8 @@ parse_ipv6_ext_hdrs__(const void **datap, size_t *sizep, > uint8_t *nw_proto, > * If a fragment header is found, '*frag_hdr' is set to the fragment > * header and otherwise set to NULL. If it is the first fragment, > * extension header parsing otherwise continues as usual. If it's not > - * the first fragment, 'nw_proto' is set to IPPROTO_FRAGMENT and 'nw_frag' > - * has FLOW_NW_FRAG_LATER set. Both first and later fragments have > - * FLOW_NW_FRAG_ANY set in 'nw_frag'. > + * the first fragment, 'nw_frag' has FLOW_NW_FRAG_LATER set. Both first > + * and later fragments have FLOW_NW_FRAG_ANY set in 'nw_frag'. > * > * A return value of false indicates that there was a problem parsing > * the extension headers.*/ > -- > 1.8.3.1 > > > [email protected] > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
