On 4/14/22 11:34, Vlad Buslov wrote:
> From: Roi Dayan <[email protected]>
> 
> Even though cited commit states that userspace declaration of
> OVS_KEY_ATTR_IPV6_EXTHDRS is not required, without it TC offload of IPv6
> flows fails with following error:
> 
> 2022-04-08T19:47:12.405Z|00001|odp_util(handler1)|ERR|internal error parsing 
> flow key 
> recirc_id(0),dp_hash(0),skb_priority(0),in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0),ct_label(0),eth(src=e4:f9:05:08:00:02,dst=33:33:00:00:00:
> 16),eth_type(0x86dd),ipv6(src=fe80::e6f9:5ff:fe08:2,dst=ff02::16,label=0,proto=58,tclass=0,hlimit=1,frag=no)(bad
>  key length 2, expected -1)(40 00),icmpv6(type=143,code=0)
> 
> To fix the error until proper IPv6 extensions support is implemented, add
> the attribute OVS_KEY_ATTR_IPV6_EXTHDRS and skip it with a warning during
> parsing.

Hi.  Thanks for looking at this issue, but I don't think that is a
correct solution.  Offloading will be broken again once anything new
is added to the kernel.  We need to make OVS to correctly handle
ODP_FIT_TOO_MUCH case instead.  In general, I think, it should be
safe to just ignore it.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to