On 4/26/22 11:59, Phelan, Michael wrote: > >> -----Original Message----- >> From: Ilya Maximets <[email protected]> >> Sent: Tuesday 26 April 2022 10:02 >> To: [email protected]; Phelan, Michael >> <[email protected]> >> Cc: [email protected]; [email protected]; >> [email protected]; Van Haaren, Harry >> <[email protected]>; Aaron Conole <[email protected]>; >> Stokes, Ian <[email protected]> >> Subject: Re: [PATCH v2] dpif-netdev-avx512: fix ubsan shift error in bitmasks >> >> On 4/22/22 15:45, Harry van Haaren wrote: >>> The code changes here are to handle (1 << i) shifts where 'i' is the >>> packet index in the batch, and 1 << 31 is an overflow of the signed '1'. >>> >>> Fixed by adding UINT32_C() around the 1 character, ensuring compiler >>> knows the 1 is unsigned (and 32-bits). Undefined Behaviour sanitizer >>> is now happy with the bit-shifts at runtime. >>> >>> Suggested-by: Ilya Maximets <[email protected]> >>> Signed-off-by: Harry van Haaren <[email protected]> >>> >>> --- >>> >>> v2: >>> - Suggested improvements to change 1ULL to UINT32_C(1) (David, Eelco) >>> - Squashed the MFEX avx512 fixup into this patch >>> >>> Thanks Ilya for the detail in the email - reworked as commit message; >>> https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393270.html >>> >>> --- >>> lib/dpif-netdev-avx512.c | 10 +++++----- >>> lib/dpif-netdev-extract-avx512.c | 2 +- >>> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> Hey, Michael. >> >> Is Intel CI alive? I can't find a report for this patch. >> It seems that the last report was sent about a week ago. > Hey Ilya, > > Yes the CI is still running, the account credentials were not up to date on > Jenkins so the emails were not being sent. > I've updated them now and will rerun the tests from the last week or so that > are missing report emails.
OK. Thanks! > > Thanks, > Michael. > > >> >> Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
