Thank you Ilya and Aaron. Best,
*Vasu Dasari* On Thu, Apr 28, 2022 at 4:50 PM Ilya Maximets <[email protected]> wrote: > On 4/27/22 17:33, Aaron Conole wrote: > > Vasu Dasari <[email protected]> writes: > > > >> Extended OpenFlow monitoring support > >> * OpenFlow 1.3 with ONF extensions > >> * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. > >> > >> ONF extensions are similar to Nicira extensions except for > onf_flow_monitor_request{} > >> where out_port is defined as 32-bit number OF(1.1) number, oxm match > formats are > >> used in update and request messages. > >> > >> Flow monitoring support in 1.4+ is slightly different from Nicira and > ONF > >> extensions. > >> * More flow monitoring flags are defined. > >> * Monitor add/modify/delete command is intruduced in flow_monitor > >> request message. > >> * Addition of out_group as part of flow_monitor request message > >> > >> Description of changes: > >> 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow > Monitoring messages. > >> include/openvswitch/ofp-msgs.h > >> > >> 2. Modify openflow header files with protocol specific headers. > >> include/openflow/openflow-1.3.h > >> include/openflow/openflow-1.4.h > >> > >> 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages > enums > >> from on nicira extensions for creating protocol abstraction headers. > OF(1.4+) > >> enums are superset of nicira extensions. > >> include/openvswitch/ofp-monitor.h > >> > >> 4. Changes to these files reflect encoding and decoding of new protocol > messages. > >> lib/ofp-monitor.c > >> > >> 5. Changes to mmodules using ofp-monitor APIs. Most of the changes here > are to > >> migrate enums from nicira to OF 1.4+ versions. > >> ofproto/connmgr.c > >> ofproto/connmgr.h > >> ofproto/ofproto-provider.h > >> ofproto/ofproto.c > >> > >> 6. Extended protocol decoding tests to verify all protocol versions > >> FLOW_MONITOR_CANCEL > >> FLOW_MONITOR_PAUSED > >> FLOW_MONITOR_RESUMED > >> FLOW_MONITOR request > >> FLOW_MONITOR reply > >> tests/ofp-print.at > >> > >> 7. Modify flow monitoring tests to be able executed by all protocol > versions. > >> tests/ofproto.at > >> > >> 7. Modified documentation highlighting the change > >> utilities/ovs-ofctl.8.in > >> NEWS > >> > >> Signed-off-by: Vasu Dasari <[email protected]> > >> Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html > >> --- > > > > Same as previous - looks good, but needs a respin due to NEWS > > > > Acked-by: Aaron Conole <[email protected]> > > Thanks, Vasu. That's a lot of work! Sorry that it took so long. > > Thanks, Aaron, for review and reminding me about these patches! > > I rebased both patches and applied to master. > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
