On 5/4/22 12:10, Stokes, Ian wrote: >>> Thanks for the review David, much appreciated. >>> >>> @Ilya Maximets are there any other blockers at this point on this series? I >>> think >> this is good to go from my side also but wanted to check with yourself if >> outstanding issues you've flagged are resolved? >> >> The code changes looks fine, but I didn't test this version. >> >> I'm not sure if we need a NEWS entry for this change as it's >> only sort of user-visible. In any case, the current version >> of the NEWS entry isn't really informative as it's unclear >> for someone, who doesn't know the code, what does it mean. >> Even from the developer's point of view it kind of lost its >> meaning in v10. What do you think? > > I would be inclined to agree, its not a new feature as such and unless > familiar with the code itself will raise more questions than answers, I can > strip the NEWS item on commit if that suits?
Sounds OK to me. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
