On 10 May 2022, at 9:23, Simon Horman wrote:
> On Tue, May 03, 2022 at 03:08:28AM +0000, Jianbo Liu wrote:
>> This series is to add support for tc offloading of ovs metering, and
>> enhance OVS to use new kernel feature which offload tc police action to
>> hardware.
>> To do the offloading, new APIs for meter are added in netdev-offload,
>> and OVS meters are mapped to tc police actions with one-to-one
>> relationship for dpif-netlink.
>
> ...
>
> Hi Jianbo,
>
> Thanks for revising the patchset.
>
> My colleagues at Corigine have exercised this patchset and have verified
> it for our test-cases.
>
> Also, I have run the upstream test workflows over them, and they look good.
>
> 1. netdev-offload: Add meter offload API
> https://github.com/horms2/ovs/actions/runs/2267288971
> 2. tc: Add support parsing tc police action
> https://github.com/horms2/ovs/actions/runs/2267290094
> 3. netdev-linux: Refactor put police action netlink message
> https://github.com/horms2/ovs/actions/runs/2267290628
> 4. netdev-linux: Add functions to manipulate tc police action
> https://github.com/horms2/ovs/actions/runs/2267292208
> 5. netdev-offload-tc: Implement and register meter offload API for tc
> https://github.com/horms2/ovs/actions/runs/2267293408
> 6. netdev-offload-tc: Cleanup police actions with reserved indexes on startup
> https://github.com/horms2/ovs/actions/runs/2267293841
> 7. netdev-offload-tc: Offloading rules with police actions
> https://github.com/horms2/ovs/actions/runs/2267294499
> 8. dpif-netlink: Offloading meter to tc police action
> https://github.com/horms2/ovs/actions/runs/2267294940
>
> I have also reviewed the patches, and with my OVS maintainer hat on, I'm
> happy to apply them, and plan to do so in the coming days unless there are
> objections.
Hi Simon/Jianbo,
I was on PTO for the last two weeks, and I wanted to take a look as some of
this patch might collide with the following patch also online
https://patchwork.ozlabs.org/project/openvswitch/list/?series=297328.
I hope to get some time late this week, or early next week. Would it be ok to
hold off until my review?
Cheers,
Eelco
> Kind regards,
> Simon
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev