Hi, thanks for the detailed comments. will submit a new version.
Eelco Chaudron <[email protected]> 于2022年5月9日周一 16:35写道： > > > On 1 May 2022, at 4:17, Peng He wrote: > > > add a rcu_barrier before close_dpif_backer to ensure that > > all meters has been freed before id_pool_destory meter's > > id-pool. > > > > Signed-off-by: Peng He <[email protected]> > > Tested-by: David Marchand <[email protected]> > > --- > > ofproto/ofproto-dpif.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > > index a4c44052d..a095a6a91 100644 > > --- a/ofproto/ofproto-dpif.c > > +++ b/ofproto/ofproto-dpif.c > > @@ -1848,6 +1848,8 @@ destruct(struct ofproto *ofproto_, bool del) > > > > seq_destroy(ofproto->ams_seq); > > > > + /* wait for all the meter destroy work finished */ > > Change comment to: > > /* Wait for all the meter destroy work to finish. */ > > > + ovsrcu_barrier(); > > close_dpif_backer(ofproto->backer, del); > > } > > > > -- > > 2.25.1 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > -- hepeng _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
