On 5/10/22 18:16, Stokes, Ian wrote: >>> Hi Ilya, >>> >>> Please find my replies inline. >> >> Hi all, this patch seems to have hit a wall, I can see there is a v6 that >> came after >> this that has been acked: >> http://patchwork.ozlabs.org/project/openvswitch/patch/20220329101724.3148 >> [email protected]/ >> >> I would like to see this work go in, but think we should finish the >> discussion on >> this tread before proceeding. My thoughts below on the discussion. > > HI All, > > Just a ping on this thread, there doesn't seem to be any response since last > week, the technical issues seem to have been resolved in the Acked- v6 . > Unless there are any further discussion I was going to merge this tomorrow?
Hi. Sorry, got sidetracked by other issues. I thought we reached the conclusion on this patch during the patch review meeting a few weeks ago. We were discussing it with Cian, not sure if you were there. And the conclusion was to not have this patch as it is a duplication of the same info that can be acquired in a different way. However, when I had a chance to run a few tests for hashing patches, I noticed that it is indeed a gap in a user experience. So, I guess, it's OK to have this change. At the same time, I think, if we're going to accept this change, the subtable-lookup-prio-get command has to be re-named, because the name will no longer match with the data this command shows. For the dp-extra-info, I'm not sure if we need that patch if we're going to accept the counters. The reason is the same - duplicated functionality. Once introduced, it's hard to get rid of duplicates. E.g. we still need to do something with pmd-stats-show and pmd-perf-show. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
