Hi Mark This is fixing a backward compatibility issue when using an older ovn-northd. ovn-controller should only set Port_Binding.up field if the Southbound DB is aware of this field (or transaction would fail). We already do this when setting pb up through notification (if-status module).
More explanations on commit 8b45fc9b2 from Dumitru. Thanks Xavier On Tue, May 10, 2022 at 8:12 PM Mark Michelson <[email protected]> wrote: > Hi Mary, > > I'm confused by this change. The summary mentions ovn-northd being at an > older version, but there's no version check being performed in the > patch. Also, what constitutes an "older" version of ovn-northd? Why > shouldn't we set the port up in this case? What problem is being solved? > > On 5/9/22 15:28, [email protected] wrote: > > From: Mary Manohar <[email protected]> > > > > Signed-off-by: Mary Manohar <[email protected]> > > --- > > controller/binding.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/controller/binding.c b/controller/binding.c > > index e284704..e7dc537 100644 > > --- a/controller/binding.c > > +++ b/controller/binding.c > > @@ -908,7 +908,9 @@ claimed_lport_set_up(const struct sbrec_port_binding > *pb, > > if (!notify_up) { > > bool up = true; > > if (!parent_pb || (parent_pb->n_up && parent_pb->up[0])) { > > - sbrec_port_binding_set_up(pb, &up, 1); > > + if (pb->n_up) { > > + sbrec_port_binding_set_up(pb, &up, 1); > > + } > > } > > return; > > } > > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
