On 5/16/22 10:29, Lorenzo Bianconi wrote: >> On 5/3/22 21:09, Lorenzo Bianconi wrote: >>> Do not group lflows if the corresponding datapath does not run >>> copp meters and the previous one has an associated copp entry. >>> In order to fix the issue reset lflow_ref pointer to NULL if the logical >>> router/logical flow runs a copp meter. >>> >>> Signed-off-by: Lorenzo Bianconi <[email protected]> >>> --- >> >> Hi Lorenzo, >> >> The change looks good to me. >> If I'm not wrong this should be: > > Hi Dumitru, > > thx for the review :) > >> >> Fixes: deec97274ab8 ("northd: optimize build_lb_rules routine") >> >> Would it be possible to add a test for this in ovn-northd.at? > > I guess it is not easy to add a test for it since the issue occurs based on > the > iteration order and in turn it depends on hashmap iteration. >
You're right, thanks for the follow up! Acked-by: Dumitru Ceara <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
