> -----Original Message----- > From: Amber, Kumar <[email protected]> > Sent: Tuesday 17 May 2022 18:35 > To: [email protected] > Cc: [email protected]; Ferriter, Cian <[email protected]>; Stokes, Ian > <[email protected]>; Phelan, Michael <[email protected]>; Van > Haaren, Harry <[email protected]>; Amber, Kumar > <[email protected]> > Subject: [PATCH v1] Pmd.at: fix dpcls and dpif configuration test cases. > > Without running set command first the string matching fails on get command > beacuse DPCLS prio value is different for different default builds like with > -- > enable-autovalidator build auto-validator prio is set to 255 and if the build > is a > scalar than generic value is default 255. > > The same problem is seen with dpif where re-arranging the get command > after set makes it consistent across any builds. > > Fixes: cc0a87b11c (pmd.at: Add test-cases for DPCLS and DPIF commands.) > Signed-off-by: Kumar Amber <[email protected]> > --- > tests/pmd.at | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/tests/pmd.at b/tests/pmd.at index 0a451f33c..3962dd2bd 100644 > --- a/tests/pmd.at > +++ b/tests/pmd.at > @@ -1113,15 +1113,15 @@ AT_SETUP([PMD - dpif configuration]) > OVS_VSWITCHD_START([], [], [], [--dummy-numa 0,0]) AT_CHECK([ovs-vsctl > add-port br0 p1 -- set Interface p1 type=dummy-pmd]) > > +AT_CHECK([ovs-appctl dpif-netdev/dpif-impl-set dpif_scalar], [0], [dnl > +DPIF implementation set to dpif_scalar. > +]) > + > AT_CHECK([ovs-vsctl show], [], [stdout]) AT_CHECK([ovs-appctl dpif- > netdev/dpif-impl-get | grep "dpif_scalar"], [], [dnl > dpif_scalar (pmds: 0) > ]) > > -AT_CHECK([ovs-appctl dpif-netdev/dpif-impl-set dpif_scalar], [0], [dnl -DPIF > implementation set to dpif_scalar. > -]) > - > OVS_VSWITCHD_STOP > AT_CLEANUP > > @@ -1130,13 +1130,6 @@ OVS_VSWITCHD_START([], [], [], [--dummy-numa > 0,0]) AT_CHECK([ovs-vsctl add-port br0 p1 -- set Interface p1 type=dummy- > pmd]) > > AT_CHECK([ovs-vsctl show], [], [stdout]) -AT_CHECK([ovs-appctl dpif- > netdev/subtable-lookup-prio-get | grep generic], [], [dnl > - 1 : generic > -]) > - > -AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > autovalidator], [], [dnl > - 0 : autovalidator > -]) > > AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set autovalidator > 3], [0], [dnl Lookup priority change affected 0 dpcls ports and 0 subtables. > -- > 2.25.1
Acked-by: Michael Phelan <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
