> -----Original Message-----
> From: Ilya Maximets <[email protected]>
> Sent: Wednesday 18 May 2022 11:35
> To: Mike Pattrick <[email protected]>; Ferriter, Cian <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Only hash port number when
> necessary.
>
> On 5/10/22 17:03, Mike Pattrick wrote:
> > On Fri, Apr 29, 2022 at 11:44 AM Cian Ferriter <[email protected]>
> > wrote:
> >>
> >> The hash of the port number is only needed when a DPCLS needs to be
> >> created. Move the hash calculation inside the if to accomplish this.
> >>
> >> Signed-off-by: Cian Ferriter <[email protected]>
> >> ---
> >
> > Good catch!
> >
> > Acked-by: Mike Pattrick <[email protected]>
>
> I'd guess that compiler will produce identical code in most cases,
> but the change makes the code a bit cleaner.
>
> Applied. Thanks!
>
> Best regards, Ilya Maximets.
Thanks for the review Mike and for applying Ilya.
Agreed, the compiler should clean this up for us. I was thinking of the change
as a code readability improvement rather than an optimization.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
