Thank you for the update, Mary. I have pushed the change to main, branch-22.03, and branch-21.12.

On 5/18/22 14:21, [email protected] wrote:
From: Mary Manohar <[email protected]>

This patch is fixing a backward compatibility issue when using an older
ovn-northd (20.09).
The 20.09 Southbound schema is not aware of the 'up'
field in the Port_Binding table. ovn-controller should set
Port_Binding.up field only if the Southbound DB
is aware of this field (or transaction would fail).

Signed-off-by: Mary Manohar <[email protected]>
---
  controller/binding.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/controller/binding.c b/controller/binding.c
index e284704..e7dc537 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -908,7 +908,9 @@ claimed_lport_set_up(const struct sbrec_port_binding *pb,
      if (!notify_up) {
          bool up = true;
          if (!parent_pb || (parent_pb->n_up && parent_pb->up[0])) {
-            sbrec_port_binding_set_up(pb, &up, 1);
+            if (pb->n_up) {
+                sbrec_port_binding_set_up(pb, &up, 1);
+            }
          }
          return;
      }


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to