Hello Adrian, On Fri, May 6, 2022 at 3:52 PM Adrian Moreno <[email protected]> wrote: > >> If openvswitch is not installed in the default system's path ovs-save > >> script will fail to find the tools it requires. > >> > >> Fix this by adding $bindir to the PATH. > > > > Seeing how we have similar code in other scripts (ovs-ctl, > > ovs-kmod-ctl), would it make sense to move this to ovs-lib? > > > > You're right, it does make sense. I initially thought of that but I ended up > discarding the idea because ovs-lib is also used in other scripts where > modifying the PATH is not needed (like xenserver/etc_init.d_openvswitch) and > because in this case I intentionally don't add $sbindir that is included in > other scripts like ovs-ctl. > > But I don't have a strong opinion, and it is cleaner to move it to ovs-lib. > Maybe we can create a couple of variables (e.g: OVS_BIN_PATH and > OVS_SBIN_PATH) > in ovs-lib and let each script use the one it needs?
Sorry, it fell through the cracks.. Your proposal lgtm. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
