On 5/18/22 20:24, Dumitru Ceara wrote: > On 5/18/22 20:00, Ilya Maximets wrote: >> On 5/16/22 09:40, Dumitru Ceara wrote: >>> On 5/7/22 00:55, Ilya Maximets wrote: >>>> Implementation of SHA1 in OpenSSL library is much faster and optimized >>>> for all available CPU architectures and instruction sets. OVS should >>>> use it instead of internal implementation if possible. >>>> >>>> Depending on compiler options OpenSSL's version finishes our sha1 >>>> unit tests from 3 to 12 times faster. Performance of OpenSSL's >>>> version is constant, but OVS's implementation highly depends on >>>> compiler. Interestingly, default build with '-g -O2' works faster >>>> than optimized '-march=native -Ofast'. >>>> >>>> Tests with ovsdb-server on big databases shows ~5-10% improvement of >>>> the time needed for database compaction (sha1 is only a part of this >>>> operation), depending on compiler options. >>>> >>>> We still need internal implementation, because OpenSSL can be not >>>> available on some platforms. Tests enhanced to check both versions >>>> of API. >>>> >>>> Signed-off-by: Ilya Maximets <[email protected]> >>>> --- >>> >>> Hi Ilya, >>> >>> I'm no openssl expert so this is a rather shallow review. In any case, >>> the change looks good to me overall. I left a question below and a >>> minor nit comment. >>> >>> Regardless: >>> >>> Reviewed-by: Dumitru Ceara <[email protected]>
Thanks! I fixed the comment and applied the patch. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
