On Mon, Jun 6, 2022 at 6:47 AM Ales Musil <[email protected]> wrote: > > Add new option for LSP called 'localnet_learn_fdb', > which will allow localnet LSP to add entries to FDB > when set to true. The default is false. > > --- > v2: Address comments and rebase on main
Thanks for the v2. I applied both the patches to the main branch with the below minor changes in patch 2. ------- diff --git a/tests/ovn.at b/tests/ovn.at index c0ade387d3..59d51f3e03 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -31973,6 +31973,7 @@ check test "$snat_zone" = "$SNAT_ZONE_REG" OVN_CLEANUP([hv1]) AT_CLEANUP +OVN_FOR_EACH_NORTHD([ AT_SETUP([OVN FDB (MAC learning) - Localnet]) ovn_start @@ -32020,18 +32021,21 @@ AT_CHECK([ovn-nbctl --wait=hv sync]) # Learning is disabled, the table should be empty send_packet 20 +AT_CHECK([ovn-nbctl --wait=hv sync]) AT_CHECK([test $(ovn-sbctl list fdb | grep -c "00:00:00:00:10:20") = 0]) # Enable learning on localnet port AT_CHECK([ovn-nbctl set logical_switch_port ln_port options:localnet_learn_fdb=true]) AT_CHECK([ovn-nbctl --wait=hv sync]) send_packet 20 +AT_CHECK([ovn-nbctl --wait=hv sync]) AT_CHECK([test $(ovn-sbctl list fdb | grep -c "00:00:00:00:10:20") = 1]) # Disable learning on localnet port AT_CHECK([ovn-nbctl set logical_switch_port ln_port options:localnet_learn_fdb=false]) AT_CHECK([ovn-nbctl --wait=hv sync]) send_packet 30 +AT_CHECK([ovn-nbctl --wait=hv sync]) AT_CHECK([test $(ovn-sbctl list fdb | grep -c "00:00:00:00:10:30") = 0]) OVN_CLEANUP([hv1]) ------- I added ovn-nbctl --wait=hv sync before the checks to eliminate any test flakes due to timing issues. Numan > > Ales Musil (2): > northd.c: Add lsp_is_localnet helper method > northd.c: Add option to enable MAC learning on localnet > > NEWS | 2 ++ > northd/northd.c | 42 +++++++++++++++++++---------- > ovn-nb.xml | 7 +++++ > ovn-sb.xml | 1 + > tests/ovn-northd.at | 36 +++++++++++++++++++++++++ > tests/ovn.at | 65 +++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 139 insertions(+), 14 deletions(-) > > -- > 2.35.3 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
