On 5/30/22 21:07, Frode Nordahl wrote:
> In some circumstances a flow may get its ct_state set without
> conscious intervention by the OVS user space code.
>
> Commit 355fef6f2ccbc optimizes out uneccessary ct_clear actions
> based on an internal struct xlate_ctx->conntracked state flag.
>
> Before this commit the xlate_ctx->conntracked state flag would
> be initialized to 'false' and only set during thawing for
> recirculation.
>
> This patch checks the flow ct_state for the non-recirc case and
> sets the internal conntracked state appropriately. A system
> traffic test is also added to avoid regression.
>
> Fixes: 355fef6f2ccbc ("ofproto-dpif-xlate: Avoid successive ct_clear datapath
> actions.")
> Signed-off-by: Frode Nordahl <[email protected]>
> ---
> ofproto/ofproto-dpif-xlate.c | 6 +++++
> tests/system-traffic.at | 46 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 52 insertions(+)
Thanks! Applied and backported down to 2.13.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev