lic121 <[email protected]> writes:

> lldp_create() malloc memory for lldp->lldpd->g_hardware. lldp_unref
> is supposed to free the memory regardless of hw->h_flags.
>
> Signed-off-by: lic121 <[email protected]>
> Acked-by: Eelco Chaudron <[email protected]>
> ---
>  lib/lldp/lldpd.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/lib/lldp/lldpd.c b/lib/lldp/lldpd.c
> index 403f1f5..4bff7b0 100644
> --- a/lib/lldp/lldpd.c
> +++ b/lib/lldp/lldpd.c
> @@ -140,13 +140,9 @@ lldpd_cleanup(struct lldpd *cfg)
>      VLOG_DBG("cleanup all ports");
>  
>      LIST_FOR_EACH_SAFE (hw, h_entries, &cfg->g_hardware) {
> -        if (!hw->h_flags) {
> -            ovs_list_remove(&hw->h_entries);
> -            lldpd_remote_cleanup(hw, NULL, true);
> -            lldpd_hardware_cleanup(cfg, hw);
> -        } else {
> -            lldpd_remote_cleanup(hw, NULL, false);
> -        }
> +        ovs_list_remove(&hw->h_entries);
> +        lldpd_remote_cleanup(hw, NULL, true);
> +        lldpd_hardware_cleanup(cfg, hw);
>      }
>  
>      VLOG_DBG("cleanup all chassis");


Acked-by: Paolo Valerio <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to