On Fri, Jun 3, 2022 at 5:17 PM Mike Pattrick <[email protected]> wrote: > > From: Flavio Leitner <[email protected]> > > Currently 'p' and 'b' and used for packets, so use > a convention that struct dp_packet is 'p' and > struct dp_packet_batch is 'b'. > > Some comments needed new formatting to not pass the > 80 column. > > Some variables were using 'p' or 'b' were renamed > as well. > > There should be no functional change with this patch.
Hopefully ;-). > > Signed-off-by: Flavio Leitner <[email protected]> > Co-authored-by: Mike Pattrick <[email protected]> > Signed-off-by: Mike Pattrick <[email protected]> Just a note, as it is not clear from the commitlog which criteria was used to do those renames out of dp-packet.* files. There are remaining places where the convention on dp_packet is not respected. lib/packets.c:compose_rarp(struct dp_packet *b, const struct eth_addr eth_src) lib/packets.c:eth_compose(struct dp_packet *b, const struct eth_addr eth_dst, lib/packets.c:compose_arp(struct dp_packet *b, uint16_t arp_op, lib/packets.c:compose_arp__(struct dp_packet *b) lib/packets.c:compose_nd_ns(struct dp_packet *b, const struct eth_addr eth_src, lib/packets.c:compose_nd_na(struct dp_packet *b, lib/packets.c:compose_nd_ra(struct dp_packet *b, lib/packets.c:packet_put_ra_prefix_opt(struct dp_packet *b, Did you skip those because they were not calling functions from the dp_packet API? -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
