On Mon, Jun 13, 2022 at 3:00 PM Ihar Hrachyshka <[email protected]> wrote:
>
> [ -z $string ] needs double quotes to handle zero-length strings
> properly.
>
> Fixes: 09dc4866fd32 ("Handle re-used pids in pidfile_is_running")
> Signed-off-by: Ihar Hrachyshka <[email protected]>
I still see the same issue with this patch.
If I remove ' >/dev/null 2>&1' I see the below error
/usr/share/ovn/scripts/ovn-ctl restart_northd
ovn-northd is not running.
Exiting ovnnb_db (1045).
Exiting ovnsb_db (1061).
Starting ovsdb-nb.
Starting ovsdb-sb.
/usr/share/ovn/scripts/ovn-ctl: line 53: [: too many arguments
OVN Northbound DB is not running : /var/run/ovn/ovnnb_db.pid ... failed!
I think there is an issue when pidfile_is_running() is called passing
when the 2nd argument is not passed.
Numan
> ---
> utilities/ovn-ctl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
> index e2f05915b..46cbac4c2 100755
> --- a/utilities/ovn-ctl
> +++ b/utilities/ovn-ctl
> @@ -43,7 +43,7 @@ ovn_ic_db_conf_file="$ovn_etcdir/ovn-ic-db-params.conf"
> pidfile_is_running () {
> pidfile=$1
> cmd=$2
> - test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` &&
> pid_exists "$pid" && [ -z $cmd -o pid_comm_check "$cmd" "$pid" ]
> + test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` &&
> pid_exists "$pid" && [ -z "$cmd" -o pid_comm_check "$cmd" "$pid" ]
> } >/dev/null 2>&1
>
> stop_nb_ovsdb() {
> --
> 2.34.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
