Hi Mark,

addressed in v2.

Thanks,
Ales

On Wed, Jun 15, 2022 at 8:13 PM Mark Michelson <mmich...@redhat.com> wrote:

> On 6/14/22 09:49, Ales Musil wrote:
> > Add stopwatch fro MAC bidning aging so
> > we can observe how long are the aging
> > check taking.
> >
> > Reported-at: https://bugzilla.redhat.com/2084668
> > Signed-off-by: Ales Musil <amu...@redhat.com>
> > ---
> >   controller/ovn-controller.c | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
> > index f33eb43d4..f91efadf5 100644
> > --- a/controller/ovn-controller.c
> > +++ b/controller/ovn-controller.c
> > @@ -110,6 +110,7 @@ static unixctl_cb_func debug_delay_nb_cfg_report;
> >   #define OFCTRL_SEQNO_RUN_STOPWATCH_NAME "ofctrl-seqno-run"
> >   #define BFD_RUN_STOPWATCH_NAME "bfd-run"
> >   #define VIF_PLUG_RUN_STOPWATCH_NAME "vif-plug-run"
> > +#define MAC_BIDNING_AGING_STOPWATCH_NAME "mac-binding-aging"
> >
> >   #define OVS_NB_CFG_NAME "ovn-nb-cfg"
> >   #define OVS_NB_CFG_TS_NAME "ovn-nb-cfg-ts"
> > @@ -3441,6 +3442,7 @@ main(int argc, char *argv[])
> >       stopwatch_create(OFCTRL_SEQNO_RUN_STOPWATCH_NAME, SW_MS);
> >       stopwatch_create(BFD_RUN_STOPWATCH_NAME, SW_MS);
> >       stopwatch_create(VIF_PLUG_RUN_STOPWATCH_NAME, SW_MS);
> > +    stopwatch_create(MAC_BIDNING_AGING_STOPWATCH_NAME, SW_MS);
>
> Throughout the file:
>
> s/BIDNING/BINDING/
>
> >
> >       /* Define inc-proc-engine nodes. */
> >       ENGINE_NODE_WITH_CLEAR_TRACK_DATA_IS_VALID(ct_zones, "ct_zones");
> > @@ -3956,12 +3958,16 @@ main(int argc, char *argv[])
> >                               stopwatch_stop(VIF_PLUG_RUN_STOPWATCH_NAME,
> >                                              time_msec());
> >                           }
> > +
> stopwatch_start(MAC_BIDNING_AGING_STOPWATCH_NAME,
> > +                                        time_msec());
> >                           mac_binding_aging_run(ovnsb_idl_txn
> ,br_int->name,
> >                                                 chassis,
> >
>  sbrec_mac_binding_table_get
> >                                                     (ovnsb_idl_loop.idl),
> >
>  sbrec_mac_biding_by_chassis,
> >                                                 60000);
> > +                        stopwatch_stop(MAC_BIDNING_AGING_STOPWATCH_NAME,
> > +                                       time_msec());
> >                           stopwatch_start(PINCTRL_RUN_STOPWATCH_NAME,
> >                                           time_msec());
> >                           pinctrl_run(ovnsb_idl_txn,
> >
>
>

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA <https://www.redhat.com>

amu...@redhat.com    IM: amusil
<https://red.ht/sig>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to