On 14 Jun 2022, at 13:57, Emma Finn wrote: > The IP checksum field was invalid in the input packets > for some unit tests. The unit tests will still pass without > a valid checksum, however we should still fix these. > > Signed-off-by: Emma Finn <[email protected]> > Acked-by: Eelco Chaudron <[email protected]> > > --- > This was found using the autovalidator introduced later in > this series. > ---
Although I've ACKed this patch in the previous series, I now concluded that these checksum failures are ok to keep in. So I think this patch can be removed from the series. This has to do with the general way OVS as a layer two switch is supposed to deal with checksums (and failures). If the checksum was already bad to begin with, it should not try to correct the checksum, as now an invalid packet has become valid. It should only change the checksum according to the data changed. Also, see comments on patch 11. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
