On 6/24/22 16:19, Dumitru Ceara wrote:
> On 6/21/22 13:47, Ilya Maximets wrote:
>> The test doesn't wait for old flows being revalidated before sending
>> the second packet. The packet hits old flows and doesn't increase the
>> new drop counter as a result.
>>
>> Solution is to wait for revalidators to clean up old flows. This fixes
>> frequent test failures on CirrusCI.
>>
>> Fixes: a13a0209750c ("userspace: Improved packet drop statistics.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>> ---
>> tests/drop-stats.at | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/tests/drop-stats.at b/tests/drop-stats.at
>> index f3e19cd83..1d3af98da 100644
>> --- a/tests/drop-stats.at
>> +++ b/tests/drop-stats.at
>> @@ -83,6 +83,9 @@ AT_CHECK([
>> ovs-ofctl -Oopenflow13 add-flows br0 flows.txt
>> ovs-ofctl -Oopenflow13 dump-flows br0 | ofctl_strip | sort | grep
>> actions ], [0], [ignore])
>>
>> +ovs-appctl time/warp 15000
>> +AT_CHECK([ovs-appctl revalidator/wait])
>> +
>> AT_CHECK([
>> ovs-appctl netdev-dummy/receive p1
>> 'in_port(1),packet_type(ns=0,id=0),eth(src=3a:6d:d2:09:9c:ab,dst=1e:2c:e9:2a:66:9e),ipv4(src=192.168.10.10,dst=192.168.10.30,proto=1,tos=0,ttl=64,frag=no),icmp(type=8,code=0)'
>> ], [0], [ignore])
>
> Makes sense.
>
> Acked-by: Dumitru Ceara <[email protected]>
Thanks! Applied and backported down to 2.13.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
