> -----Original Message-----
> From: Ilya Maximets <[email protected]>
> Sent: Tuesday, June 28, 2022 1:07 AM
> To: David Marchand <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Van Haaren, Harry
> <[email protected]>; Ferriter, Cian <[email protected]>;
> Pai G, Sunil <[email protected]>
> Subject: Re: [PATCH] dpif-netdev: Refactor AVX512 runtime checks.
>
> On 6/24/22 09:29, David Marchand wrote:
> > As described in the bugzilla below, cpu_has_isa code may be compiled
> > with some AVX512 instructions in it, because cpu.c is built as part of
> > the libopenvswitchavx512.
> > This is a problem when this function (supposed to probe for AVX512
> > instructions availability) is invoked from generic OVS code, on older
> > CPUs that don't support them.
> >
> > For the same reason, dpcls_subtable_avx512_gather_probe,
> > dp_netdev_input_outer_avx512_probe, mfex_avx512_probe and
> > mfex_avx512_vbmi_probe are potential runtime bombs and can't either be
> > built as part of libopenvswitchavx512.
> >
> > Move cpu.c to be part of the "normal" libopenvswitch.
> > And move other helpers in generic OVS code.
> >
> > Note:
> > - dpcls_subtable_avx512_gather_probe is split in two, because it also
> > needs to do its own magic,
> > - while moving those helpers, prefer direct calls to cpu_has_isa and
> > avoid cast to intermediate integer variables when a simple boolean
> > is enough,
> >
> > Fixes: b366fa2f4947 ("dpif-netdev: Call cpuid for x86 isa
> > availability.")
> > Reported-at: https://bugzilla.redhat.com/2100393
> > Reported-by: Ales Musil <[email protected]>
> > Signed-off-by: David Marchand <[email protected]>
> > ---
>
> Thanks, David and Ales. The change looks good to me in general.
>
> Cian, Sunil, could you, please, take a look?
>
> The issue is causing failures in upstream OpenStack CI.
> We'll also need to backport this change to stable branches.
>
> Best regards, Ilya Maximets.
The patch looks good to me. I'm happy to ack.
Acked-by: Sunil Pai G <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
