On 6/29/22 10:16, Ales Musil wrote: > > > On Wed, Jun 29, 2022 at 9:32 AM David Marchand <[email protected] > <mailto:[email protected]>> wrote: > > As described in the bugzilla below, cpu_has_isa code may be compiled > with some AVX512 instructions in it, because cpu.c is built as part of > the libopenvswitchavx512. > This is a problem when this function (supposed to probe for AVX512 > instructions availability) is invoked from generic OVS code, on older > CPUs that don't support them. > > For the same reason, dpcls_subtable_avx512_gather_probe, > dp_netdev_input_outer_avx512_probe, mfex_avx512_probe and > mfex_avx512_vbmi_probe are potential runtime bombs and can't either be > built as part of libopenvswitchavx512. > > Move cpu.c to be part of the "normal" libopenvswitch. > And move other helpers in generic OVS code. > > Note: > - dpcls_subtable_avx512_gather_probe is split in two, because it also > needs to do its own magic, > - while moving those helpers, prefer direct calls to cpu_has_isa and > avoid cast to intermediate integer variables when a simple boolean > is enough, > > Fixes: 352b6c7116cd ("dpif-lookup: add avx512 gather implementation.") > Fixes: abb807e27dd4 ("dpif-netdev: Add command to switch dpif > implementation.") > Fixes: 250ceddcc2d0 ("dpif-netdev/mfex: Add AVX512 based optimized > miniflow extract") > Fixes: b366fa2f4947 ("dpif-netdev: Call cpuid for x86 isa availability.") > Reported-at: https://bugzilla.redhat.com/2100393 > <https://bugzilla.redhat.com/2100393> > Reported-by: Ales Musil <[email protected] <mailto:[email protected]>> > Co-authored-by: Ales Musil <[email protected] <mailto:[email protected]>> > Signed-off-by: Ales Musil <[email protected] <mailto:[email protected]>> > Signed-off-by: David Marchand <[email protected] > <mailto:[email protected]>> > Acked-by: Sunil Pai G <[email protected] > <mailto:[email protected]>> > --- > Changes since v1: > - restored Ales as co-author, > - added more Fixes: lines: backports go back to 2.14 and are not that > difficult > to do, but I can help if needed, > - fixed one indent issue, > > > Acked-by: Ales Musil <[email protected] <mailto:[email protected]>>
Rich-text editors are dangerous. :) Applied to master and backported to 2.17. David, if you can prepare backports for older branches, that would be great. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
