Hi Flavio, Mike,
I did have a quick look over the patch-set
https://patchwork.ozlabs.org/project/openvswitch/list/?series=307485
I have some comments over the patches mentioned below:
1. Can a Cover letter be provided with the patch-set to
understand the intent/approach of patch-set to the problem?
a. A cover letter would give the series a better
title, and a place to give a high-level overview of approach.
2. There are two big concerns with the patch-set:
a. The SW fallback patch is marked as an
_untested_ patch to showcase the proposed solution. Given its untested status,
we assume it is not a candidate for 2.18.
b. Changing of default behavior of TSO/GSO to
default ON, why is this necessary? Features are typically "opt in", what makes
TSO/GSO different?
3. Can the patch-set be split into 2 logical parts being CSUM and
TSO/GSO, any thoughts on this?
Regards
Amber
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
