> -----Original Message-----
> From: Pai G, Sunil <[email protected]>
> Sent: Monday 4 July 2022 13:27
> To: [email protected]
> Cc: [email protected]; Finn, Emma <[email protected]>; Van Haaren, Harry
> <[email protected]>; Ferriter, Cian <[email protected]>
> Subject: [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance
> readability.
>
> The preprocessor comparison string to check AVX512 capabilities are
> lengthy and effecting user readability. Simpify this by aliasing the checks.
>
> Suggested-by: Eelco Chaudron <[email protected]>
> Signed-off-by: Sunil Pai G <[email protected]>
>
> ---
> v2: rebase on master, added alias for DPCLS.
> Remove the acks since there are changes introduced because of
> rebase.
> ---
V2 changes make sense. There's are extra places where the build check is
simplified because of "dpif-netdev: Refactor AVX512 runtime checks" change.
It makes sense to add an alias for the DPCLS build time checks because it's
used in more than one place now, where that wasn't the case for the v1.
I ran the same set of tests that I usually run on these build time checks
(build with GCC 4.8, 4.9, 5 and 9) to hit cases where the compiler supports the
different subsets of AVX512 ISA. All LGTM.
Acked-by: Cian Ferriter <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
