On Thu, 2022-07-07 at 13:51 +0200, Eelco Chaudron wrote:
> On 2 Jul 2022, at 5:18, Jianbo Liu wrote:
> 
> 
> > +    tca = ofpbuf_at_assert(msg, NLMSG_HDRLEN, sizeof *tca);
> > +    act = nl_attr_find(msg, NLMSG_HDRLEN + sizeof *tca,
> > TCA_ACT_TAB);
> > +    if (!act) {
> > +        VLOG_ERR_RL(&rl, "Failed to get action stats, can't find
> > attr");
> 
> 
> A nit I missed before, but as you need to send an update rev anyway,
> please change attr to attribute in the error message, which is more
> user-friendly.
> 

OK, will change in next version. Thanks!

> > +        return EPROTO;
> > +    }
> > +
> 
> <SNIP>
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to