On 7/8/22 22:55, Rosemarie O'Riorden wrote: > This is a regression test to make sure that all later IPv6 fragments > have proto=44 in the flow key, and that there are not any later IPv6 > frag flows that do not have it. > > Previously, the way that later IPv6 fragments' nw_proto field is parsed > in the kernel was changed to equal the next_header field of the last > extension header. The same change was not made in OVS userspace. This > was a problem because OVS creates actions based on what is parsed in > userspace, but the kernel-provided flow key is used as a match criteria. > This lead to issues such as packets incorrectly matching on a flow and > thus the wrong list of actions being applied to the packet. Therefore, > OVS and the kernel must parse this field the same way to prevent this > issue. > > OVS and the kernel both currently parse this field the same way for > later IPv6 fragments, with nw_proto=44. > > Signed-off-by: Rosemarie O'Riorden <[email protected]> > --- > v2: > - Changes name of test > - Adds minimum kernel version check > > tests/system-traffic.at | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+)
I can confirm that this test actually detects the kernel issue. We could have used a different kernel version macro to exclude only kernels 4.20-5.18, but there are distribution kernels with the issue backported, so checking for 5.19+ seems like a good solution. It should be enough to prevent re-introduction of the problem. Thanks! Applied. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
