On 6/30/22 13:34, Dumitru Ceara wrote: > On 6/30/22 13:27, Ilya Maximets wrote: >> Memory trimming was introduced in OVS 2.15 and didn't cause any >> issues in production environments since then, while allowing >> ovsdb-sever to consume a lot less memory in high scale OVN >> deployments. Enabling by default to make it easier to use. >> >> Signed-off-by: Ilya Maximets <[email protected]> >> --- >> NEWS | 3 +++ >> ovsdb/ovsdb-server.c | 2 +- >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/NEWS b/NEWS >> index 994fdf6a9..ca6b4e5a3 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -21,6 +21,9 @@ Post-v2.17.0 >> configuration in a clustered databse independently for each server. >> E.g. for listening on unique addresses. See the ovsdb.local-config.5 >> manpage for schema details. >> + * Returning unused memory to the OS after the database compaction is >> now >> + enabled by default. Use 'ovsdb-server/memory-trim-on-compaction off' >> + unixctl command to disable. >> - OVSDB-IDL: >> * New monitor mode flag, OVSDB_IDL_WRITE_CHANGED_ONLY, allowing >> applications to relax atomicity requirements when dealing with >> diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c >> index 5549b4e3a..ddae685fd 100644 >> --- a/ovsdb/ovsdb-server.c >> +++ b/ovsdb/ovsdb-server.c >> @@ -80,7 +80,7 @@ static char *ssl_ciphers; >> static bool bootstrap_ca_cert; >> >> /* Try to reclaim heap memory back to system after DB compaction. */ >> -static bool trim_memory = false; >> +static bool trim_memory = true; >> >> static unixctl_cb_func ovsdb_server_exit; >> static unixctl_cb_func ovsdb_server_compact; > > I didn't compile or test this but it's obviously correct and it's how we > deploy ovsdb-server in large scale OVN setups so: > > Acked-by: Dumitru Ceara <[email protected]> >
Applied. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
