On 7/8/22 16:08, Ales Musil wrote: > > > On Fri, Jul 8, 2022 at 3:34 PM Ilya Maximets <[email protected] > <mailto:[email protected]>> wrote: > > We're adding -Werror argument twice to every compiler invocation, > if configured with --enable-Werror. The reason is the double > expansion of the OVS_ENABLE_WERROR macro. It's called once from > the top level in configure.ac <http://configure.ac> and the second time > from the > AC_REQUIRE while checking CXX compatibility. AC_REQUIRE by itself > protects from double expansion, but it can't protect from top > level calls and it can not be used outside of AC_DEFUN. > > One way to fix that is to use AC_DEFUN_ONCE for OVS_ENABLE_WERROR, > but it's not available in older autoconf < 2.64. So, creating a > separate macro with AC_REQUIRE inside for the top level invocation > to make it expanded only once. > > Signed-off-by: Ilya Maximets <[email protected] > <mailto:[email protected]>> > --- > acinclude.m4 | 4 ++++ > configure.ac <http://configure.ac> | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > > Great, thank you. > > Acked-by: Ales Musil <[email protected] <mailto:[email protected]>>
Applied. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
