On 7/12/22 19:44, Harry van Haaren wrote: > From: Emma Finn <[email protected]> > > This commit adds the AVX512 implementation of the action functionality. > > Usage: > $ ovs-appctl odp-execute/action-impl-set avx512 > > Signed-off-by: Emma Finn <[email protected]> > Acked-by: Harry van Haaren <[email protected]> > > --- > > v9: rebase conflict on NEWS > --- > Documentation/ref/ovs-actions.7.rst | 26 ++++++++++++++++++++++++++ > Documentation/topics/testing.rst | 24 ++++++++++++++++-------- > NEWS | 1 + > lib/cpu.c | 1 + > lib/cpu.h | 1 + > lib/odp-execute-private.c | 8 ++++++++ > lib/odp-execute-private.h | 6 ++++++ > 7 files changed, 59 insertions(+), 8 deletions(-) > > diff --git a/Documentation/ref/ovs-actions.7.rst > b/Documentation/ref/ovs-actions.7.rst > index b59b7634f..2410acc4a 100644 > --- a/Documentation/ref/ovs-actions.7.rst > +++ b/Documentation/ref/ovs-actions.7.rst > @@ -125,6 +125,32 @@ the one added to the set later replaces the earlier > action: > > An action set may only contain the actions listed above. > > +Actions Implementations (Experimental) > +-------------------------------------- > + > +Actions are used in OpenFlow flows to describe what to do when the flow > +matches a packet. Just like with the datapath interface, SIMD instructions > +with the userspace datapath can be applied to the action implementation to > +improve performance.
odp-execute doesn't execute OpenFlow actions, it executes datapath flow actions. These are very different things. So, the paragraph above is not correct. And the ovs-actions man page is about OpenFlow actions supported by OVS. It's about format of OpenFlow actions and the processing of the OpenFlow pipeline. It's not about datapath actions nor any other aspect of actions. This piece of documentation should be fixed and it should not be here. (Accidentally noticed that while trying to report build failure) Better move that back to Documentation/topics/dpdk/bridge.rst. It's not DPDK-specific, but there is actually nuothing DPDK-specific in the bridge.rst. We need to rename that document and move to some other palace at some point. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
