Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#811 FILE: utilities/ovs-confctl.c:304:
get-connection print the connections\n\
WARNING: Line lacks whitespace around operator
#812 FILE: utilities/ovs-confctl.c:305:
del-connection delete the connections\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#813 FILE: utilities/ovs-confctl.c:306:
[--inactivity-probe=MSECS]\n\
WARNING: Line lacks whitespace around operator
#814 FILE: utilities/ovs-confctl.c:307:
set-connection TARGET... set the list of connections to TARGET...\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#820 FILE: utilities/ovs-confctl.c:313:
--db=DATABASE connect to DATABASE\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#822 FILE: utilities/ovs-confctl.c:315:
-t, --timeout=SECS wait at most SECS seconds\n\
WARNING: Line lacks whitespace around operator
#823 FILE: utilities/ovs-confctl.c:316:
--dry-run do not commit changes to database\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#830 FILE: utilities/ovs-confctl.c:323:
--no-syslog equivalent to --verbose=conf_ctl:syslog:warn\n");
Lines checked: 1237, Warnings: 14, Errors: 0
build:
> lib/dirs.c.tmp && \
mv -f lib/dirs.c.tmp lib/dirs.c
depbase=`echo lib/dirs.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -g -O2 -MT
lib/dirs.lo -MD -MP -MF $depbase.Tpo -c -o lib/dirs.lo lib/dirs.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -g -O2 -MT lib/dirs.lo -MD -MP -MF lib/.deps/dirs.Tpo -c lib/dirs.c -o
lib/dirs.o
depbase=`echo lib/ovsdb-server-idl.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -g -O2 -MT
lib/ovsdb-server-idl.lo -MD -MP -MF $depbase.Tpo -c -o lib/ovsdb-server-idl.lo
lib/ovsdb-server-idl.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -g -O2 -MT lib/ovsdb-server-idl.lo -MD -MP -MF
lib/.deps/ovsdb-server-idl.Tpo -c lib/ovsdb-server-idl.c -o
lib/ovsdb-server-idl.o
PYTHONPATH=./python":"$PYTHONPATH PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3
./ovsdb/ovsdb-idlc.in annotate ./ovsdb/local-config.ovsschema
./lib/ovsconf-idl.ann > lib/ovsconf-idl.ovsidl.tmp && mv
lib/ovsconf-idl.ovsidl.tmp lib/ovsconf-idl.ovsidl
PYTHONPATH=./python":"$PYTHONPATH PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3
./ovsdb/ovsdb-idlc.in c-idl-source lib/ovsconf-idl.ovsidl >
lib/ovsconf-idl.c.tmp && mv lib/ovsconf-idl.c.tmp lib/ovsconf-idl.c
depbase=`echo lib/ovsconf-idl.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -g -O2 -MT
lib/ovsconf-idl.lo -MD -MP -MF $depbase.Tpo -c -o lib/ovsconf-idl.lo
lib/ovsconf-idl.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -g -O2 -MT lib/ovsconf-idl.lo -MD -MP -MF lib/.deps/ovsconf-idl.Tpo -c
lib/ovsconf-idl.c -o lib/ovsconf-idl.o
lib/ovsconf-idl.c:4:29: fatal error: lib/ovsconf-idl.h: No such file or
directory
#include "lib/ovsconf-idl.h"
^
compilation terminated.
make[2]: *** [lib/ovsconf-idl.lo] Error 1
make[2]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
