On 7/13/22 22:38, Ilya Maximets wrote:
> MSVC doesn't have pthread_t defined by default as other compilers,
> so the build fails without the header.
> 
> Fixes: 3cd2cbd684e0 ("ovsdb: Prepare snapshot JSON in a separate thread.")
> Signed-off-by: Ilya Maximets <[email protected]>
> ---
> 
> Not sure how I missed that.  Sorry.
> 

It can happen. :)

Acked-by: Dumitru Ceara <[email protected]>

>  ovsdb/ovsdb.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ovsdb/ovsdb.h b/ovsdb/ovsdb.h
> index 2f77821e0..d05e7c64a 100644
> --- a/ovsdb/ovsdb.h
> +++ b/ovsdb/ovsdb.h
> @@ -21,6 +21,7 @@
>  #include "openvswitch/list.h"
>  #include "openvswitch/shash.h"
>  #include "openvswitch/uuid.h"
> +#include "ovs-thread.h"
>  
>  struct json;
>  struct ovsdb_log;

If you agree, I'd also remove the '#include "ovs-thread.h"' from all
files that already include "ovsdb.h".  But it's not a must.

Thanks,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to