On 13 Jul 2022, at 20:27, Harry van Haaren wrote:
> This patchset introduces actions infrastructure changes which allows > the user to choose between different action implementations based on > CPU ISA by using different commands. The infrastructure also > provides a way to check the correctness of the ISA optimized action > version against the scalar version. > > This series also introduces optimized versions of the following > actions: > - push_vlan > - pop_vlan > - set_masked eth > - set_masked ipv4 > > Below is a table indicating some relative performance benefits for > these actions. > +-----------------------------------------------+-------------------+-----------------+ > | Actions | Scalar with series| AVX > with series | > +-----------------------------------------------+-------------------+-----------------+ > | mod_dl_dst | 1.01x | 1.13x > | > +-----------------------------------------------+-------------------+-----------------+ > | push_vlan | 1.01x | 1.10x > | > +-----------------------------------------------+-------------------+-----------------+ > | strip_vlan | 1.01x | 1.11x > | > +-----------------------------------------------+-------------------+-----------------+ > | mod_ipv4 1 x field | 1.01x | 1.02x > | > +-----------------------------------------------+-------------------+-----------------+ > | mod_ipv4 4 x fields | 1.01x | 1.21x > | > +-----------------------------------------------+-------------------+-----------------+ > | strip_vlan + mod_dl_dst + mod_ipv4 4 x fields | 1.01x | 1.36x > | > +-----------------------------------------------+-------------------+-----------------+ > > --- > V10; > - Fixed CI build issue on OSX around AVX512 linking (jenkins CI) > - Moved docs and reworded sections (thanks Ilya for feedback) > - Reworked one instance of <= OVS_ATTR_MAX back to original form(Eelco) I’ve just finished my review purely based on visual inspection and compile success, and I will send out some minor comments after the break ;) After that, I will do the actual functional testing on an AVX512 machine and let you know the results. This will give you time to fix/discuss the comment while I’m testing. Cheers, Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
