On 13 Jul 2022, at 20:27, Harry van Haaren wrote: > From: Emma Finn <[email protected]> > > This commit removes the pop_vlan action from the large switch > and creates a separate function for batched processing. A function > pointer is also added to call the new batched function for the pop_vlan > action. > > Signed-off-by: Emma Finn <[email protected]> > Acked-by: Harry van Haaren <[email protected]>
Thanks for adding all the suggested changes, here and in the first patch. Acked-by: Eelco Chaudron <[email protected]> One small nit, maybe can be fixed at commit time? But we need a v11 anyway, so you could add it there. > --- a/lib/odp-execute-private.h > +++ b/lib/odp-execute-private.h > @@ -71,6 +71,11 @@ BUILD_ASSERT_DECL(ACTION_IMPL_SCALAR == 0); > */ > void odp_execute_action_init(void); > > +/* Init functions for the action implementations. Initializes the function > + * pointers for optimized action types. > + */ The comment ending should be on the last line. //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
