On 13 Jul 2022, at 20:28, Harry van Haaren wrote: > From: Emma Finn <[email protected]> > > This commit adds the AVX512 implementation of the action functionality. > > Usage: > $ ovs-appctl odp-execute/action-impl-set avx512 > > Signed-off-by: Emma Finn <[email protected]> > Signed-off-by: Harry van Haaren <[email protected]> > > ---
<SNIP> > diff --git a/lib/odp-execute-private.h b/lib/odp-execute-private.h > index d6eebbf37..1943eb600 100644 > --- a/lib/odp-execute-private.h > +++ b/lib/odp-execute-private.h > @@ -22,6 +22,15 @@ > #include "odp-netlink.h" > #include "ovs-atomic.h" > > +/* Combine all required ISA and Linker checks into a single #define > + * for readability and simplicity where the checks are needed. Note > + * that it is always #defined, so code must use the #if preprocesor > + * directive (not #ifdef). > + */ Please end comment on same line. > +#define ACTION_IMPL_AVX512_CHECK (__x86_64__ && HAVE_AVX512F \ > + && HAVE_LD_AVX512_GOOD && __SSE4_2__ && HAVE_AVX512BW && HAVE_AVX512VL \ > + && HAVE_GCC_AVX512VL_GOOD) > + <SNIP> Rest looks good to me. Also seems the actual ISA init code was moved to patch 7. //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
