On 7/14/22 15:05, Simon Horman wrote:
> On Thu, Jul 14, 2022 at 11:44:53AM +0200, Ilya Maximets wrote:
>> On 7/14/22 07:33, Simon Horman wrote:
>>> On Wed, Jul 13, 2022 at 04:30:41PM +0200, Ilya Maximets wrote:
>>>> Direct leak of 64 byte(s) in 1 object(s) allocated from:
>>>> 0 0x51b1d8 in malloc (vswitchd/ovs-vswitchd+0x51b1d8)
>>>> 1 0xc81ded in xmalloc__ lib/util.c:137:15
>>>> 2 0xc81ded in xmalloc lib/util.c:172:12
>>>> 3 0xb32153 in ofpbuf_new lib/ofpbuf.c:168:24
>>>> 4 0xd563e4 in nl_sock_transact lib/netlink-socket.c:1113:34
>>>> 5 0xd56261 in nl_transact lib/netlink-socket.c:1812:13
>>>> 6 0xd5e096 in tc_transact lib/tc.c:238:17
>>>> 7 0xd01622 in tc_del_policer_action lib/netdev-linux.c:5807:13
>>>> 8 0xd2e681 in meter_tc_del_policer lib/netdev-offload-tc.c:2827:15
>>>> 9 0x94ec21 in meter_offload_del lib/netdev-offload.c:245:23
>>>> 10 0xcc86c4 in dpif_netlink_meter_del lib/dpif-netlink.c:4288:9
>>>> 11 0x86c595 in dpif_meter_del lib/dpif.c:2014:13
>>>> 12 0x663439 in free_meter_id ofproto/ofproto-dpif.c:6789:5
>>>> 13 0xb47518 in ovsrcu_call_postponed lib/ovs-rcu.c:346:13
>>>> 14 0xb48031 in ovsrcu_postpone_thread lib/ovs-rcu.c:362:14
>>>> 15 0xb5015a in ovsthread_wrapper lib/ovs-thread.c:422:12
>>>> 16 0x7f86af4081ce in start_thread (/lib64/libpthread.so.0+0x81ce)
>>>>
>>>> Fixes: 5c039ddc64ff ("netdev-linux: Add functions to manipulate tc police
>>>> action")
>>>> Signed-off-by: Ilya Maximets <[email protected]>
>>>
>>> Acked-by: Simon Horman <[email protected]>
>>>
>>> I'd also be happy to apply this patch if that was your intention.
>>
>> Feel free to apply these 3 fixes, if you have time. Thanks!
>> The one about misaligned access in pedit action will also need
>> a backport to stable branches.
>>
>> Best regards, Ilya Maximets.
>
> Thanks, all patches applied to master.
>
> The pedit action fix was also applied back to branch-2.13.
> Let me know if you'd like me to backport it further back.
Thanks! We don't need to backport further as we don't support
older branches. And the fix is not critical anyway.
But it seems you missed the branch-2.14. Could you, please, recheck?
>
> I'll also reply to the other two patches for the record.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev